[WIP] Add debug logging using the new logging system #547
+1,371
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a centralized logging system to improve debugging capabilities and separate logging concerns from the Storage class. - Add logger module with configurable debug/info levels - Support runtime configuration via coder.verbose setting - Provide OutputChannelAdapter for VS Code integration - Add ArrayAdapter for isolated unit testing - Include performance benchmarks in tests - Maintain backward compatibility via Storage delegation - Update all components to use centralized logger The logger responds to configuration changes without requiring extension restart and includes source location tracking for debug messages. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…een without config
Create detailed specification for adding debug logging to connection and reconnection logic, focusing on SSH configuration, connection lifecycle tracking, and error capture with sensitive data masking. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Add comprehensive debug logging throughout the codebase to aid in troubleshooting connection issues: - Add process error handlers (uncaughtException, unhandledRejection) - Add process signal handlers (SIGTERM, SIGINT, SIGHUP) - Add memory pressure monitoring with heap usage alerts - Implement sensitive data masking for logs (SSH keys, passwords, tokens) - Add debug logging to SSH config operations with masked output - Add connection lifecycle logging with unique connection IDs - Add retry logic and backoff timing logs - Add workspace disconnection event logging - Refactor logger to separate vscode dependencies using adapter pattern - Create ConfigProvider interface for test isolation - Reorganize files into logical directories (config/, logging/, test/) - All debug logs gated by coder.verbose flag 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The debug logging implementation has been completed with: - Process error and signal handlers - Memory pressure monitoring - SSH config logging with sensitive data masking - Connection lifecycle tracking - Consistent log formatting Minor gaps remain for future enhancement: - Explicit backoff delay values in retry logs - Network timeout duration logging - HTTP error codes with connection context 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly an example PR for how the logging system might be used, if the logging system is merged in #545 more or less as is, I will work towards actually merging this.
#532